This repository was archived by the owner on Feb 12, 2022. It is now read-only.
http status code cannot be outside of range 100-599#351
Open
LorenaSoledad wants to merge 1 commit intoraml-org:masterfrom
Open
http status code cannot be outside of range 100-599#351LorenaSoledad wants to merge 1 commit intoraml-org:masterfrom
LorenaSoledad wants to merge 1 commit intoraml-org:masterfrom
Conversation
svacas
suggested changes
Mar 2, 2017
Contributor
svacas
left a comment
svacas
left a comment
There was a problem hiding this comment.
once the range is clarified in the spec we can merge this change
| protected Rule responseCodes() | ||
| { | ||
| return range(Range.closed(100L, 599L)); | ||
| return range(Range.closed(0L, 999L)); |
Contributor
There was a problem hiding this comment.
open a spec bug to clarify what should be the allowed range of status codes, otherwise next time somebody will want to use status code 1050 and it will not be possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #264